Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo upgrade as part of preparing libcnb releases #641

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Aug 18, 2023

We've been previously doing these on an adhoc basis, but it makes sense to instead just do it as part of the release.

Bumping the in-range versions ensures that consumers of libcnb get updated transitive dependencies (without having to manually refresh their own Cargo.locks) that match the dependency versions tested in CI here (since this repo correctly doesn't use a lockfile, so will be using these latest in-range versions in CI etc).

Eventually we can move all of these preparing release steps into a GitHub Actions workflow to reduce the toil of performing releases.

GUS-W-13973454.

We've been previously doing these on an adhoc basis, but it makes
sense to instead just do it as part of the release.

Bumping the in-range versions ensures that consumers of libcnb
get updated transitive dependencies (without having to manually
refresh their own `Cargo.lock`s) that match the dependency
versions tested in CI here (since this repo correctly doesn't use
a lockfile, so will be using these latest in-range versions in CI etc).

Eventually we can move all of these preparing release steps into
a GitHub Actions workflow to reduce the toil of performing releases.
@edmorley edmorley self-assigned this Aug 18, 2023
@edmorley edmorley marked this pull request as ready for review August 18, 2023 09:01
@edmorley edmorley requested a review from a team as a code owner August 18, 2023 09:01
@edmorley edmorley merged commit 4644deb into main Aug 18, 2023
5 checks passed
@edmorley edmorley deleted the edmorley/releasing-cargo-upgrade branch August 18, 2023 09:07
colincasey added a commit that referenced this pull request Aug 18, 2023
* main:
  Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647)
  Prepare release v0.14.0 (#646)
  Pin intra-libcnb* crate dependencies to exact versions (#644)
  Rename libcnb-cargo integration test file (#645)
  Add version links in the changelog (#643)
  Update Quick Start Guide (#640)
  Run `cargo upgrade` as part of preparing libcnb releases (#641)
  Move packaged buildpack directory out of `target/` (#583)
  Refactor libcnb-cargo integration tests (#637)
  libcnb-test: Improve error messages for `address_for_port` (#636)
  libcnb-test: Implement `fmt::Display` for `LogOutput` (#635)

# Conflicts:
#	CHANGELOG.md
#	libcnb-cargo/src/package/command.rs
colincasey added a commit that referenced this pull request Aug 18, 2023
…cator

* main:
  Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647)
  Prepare release v0.14.0 (#646)
  Pin intra-libcnb* crate dependencies to exact versions (#644)
  Rename libcnb-cargo integration test file (#645)
  Add version links in the changelog (#643)
  Update Quick Start Guide (#640)
  Run `cargo upgrade` as part of preparing libcnb releases (#641)
  Move packaged buildpack directory out of `target/` (#583)
  Refactor libcnb-cargo integration tests (#637)
  libcnb-test: Improve error messages for `address_for_port` (#636)
  libcnb-test: Implement `fmt::Display` for `LogOutput` (#635)

# Conflicts:
#	CHANGELOG.md
#	libcnb-cargo/src/package/command.rs
#	libcnb-cargo/src/package/error.rs
#	libcnb-cargo/tests/test.rs
#	libcnb-package/src/lib.rs
colincasey added a commit that referenced this pull request Aug 18, 2023
… libcnb-package/assembling_buildpack_directories

* libcnb-package/buildpack_output_directory_locator:
  Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647)
  Prepare release v0.14.0 (#646)
  Pin intra-libcnb* crate dependencies to exact versions (#644)
  Rename libcnb-cargo integration test file (#645)
  Add version links in the changelog (#643)
  Update Quick Start Guide (#640)
  Run `cargo upgrade` as part of preparing libcnb releases (#641)
  Move packaged buildpack directory out of `target/` (#583)
  Refactor libcnb-cargo integration tests (#637)
  libcnb-test: Improve error messages for `address_for_port` (#636)
  libcnb-test: Implement `fmt::Display` for `LogOutput` (#635)

# Conflicts:
#	CHANGELOG.md
#	libcnb-cargo/src/package/command.rs
#	libcnb-package/src/output.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants